924060929 commented on PR #63612:
URL: https://github.com/apache/doris/pull/63612#issuecomment-6678755513
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#63612
commit: 73108578c43ecebe4675e0203f7d023bf607092a
base: b6c67510385391d0dd913589f1b323ec86ba7bd6
reviewed_at: 2026-11-06T14:30+08:00
reviewer: 924060929
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 3
converged: true
```
**Notes for maintainers**
- Solo incremental review of all 43 final changed paths: 40 prepared patches
are identical to the prior full 44-path review at 34af6f3; all three updated
complete patches and the removed transaction hunk were freshly read. The valid
remote P2 was accepted in round 1, repaired, then followed by two clean rounds.
No subagents; no remaining finding.
- Fixed review comment 4489252243 by removing the VISIBLE DATA callback,
unused change-type API and full-cache scan. Native live publication/replay
retain existing partition-before-table version publication under table locks;
the transaction file is now byte-identical to the merge base. FE/BE admission
and lookup share dependency validation, retaining unchanged-partition reuse.
Metadata-only revision fences and per-cache exception isolation remain; no
journal, async task or executing-context registry was added.
- The identical deterministic no-cache-visit test fails on the previous
implementation and passes after repair. Actual lookup controls cover
modified/unmodified partitions, other tables, table-wide fallback and
partitioned/nonpartitioned COMMITTED/VISIBLE timing. Preset FE UT passes 13
classes / 210 cases with zero failures/errors/skips; build.sh --fe, integrated
Checkstyle and git diff --check pass. Validated source hashes match this
commit. Builds/tests occurred in the repair phase; final review was read-only.
- Initial-head vault build 1094611 failed preparation because another
apt-get held the apt lists lock and docker-compose could not be installed;
deployment/test steps were skipped. No unrelated CI installer change or claim
that vault passed. Initial-head pending FE UT/regressions are not credited as
this commit's validation. New remote CI/review is separate; no full FE, new
multi-FE/remote-connector, BE/Cloud runtime or benchmark result is claimed this
turn.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
