morningman commented on PR #69929: URL: https://github.com/apache/doris/pull/69929#issuecomment-6679187988
Thank you, @Aranya7, for investigating this issue and contributing the fix and recovery tests. I compared this PR with #70121, which was merged into master on November 5. That change addresses the recovery of all four properties covered here: `max_filter_ratio`, `exec_mem_limit`, `send_batch_parallelism`, and `load_to_single_tablet`. The merged implementation restores the filter ratio, parallelism, and single-tablet setting from the persisted job properties, preserving an altered filter ratio. It restores `exec_mem_limit` from the original CREATE statement, which is sufficient because ALTER ROUTINE LOAD does not support changing that property. I'm closing this PR as superseded by #70121. We appreciate the work you put into identifying the problem and covering the recovery scenarios. If you find a case that remains affected after #70121, please share it so we can follow up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
