eldenmoon commented on PR #70363:
URL: https://github.com/apache/doris/pull/70363#issuecomment-6703594249
Update in this branch:
- The scan guard now checks the cast source type explicitly (Variant)
instead of skipping every `CAST_EXPR`; behaviour is unchanged for the reachable
shape, but the condition no longer relies on the implicit precondition in
`is_valid_push_down_cast`.
- Added `variant_p0/test_variant_cast_isnull_pushdown` covering `CAST(v AS
INT) IS NULL`, `IS NOT NULL` and `<=> NULL` over a `VARIANT NOT NULL` column
(the existing `is_null_filter` used a STRING cast where every row is non-null,
so it could not catch a removed guard).
- Data note: the new case uses only `'1'`, `'"x"'` and `'[1,2]'`. `{"a":1}`
is avoided because 4.1 casts it to 0 while 4.2 casts it to NULL; string and
array values are NULL on both branches, so the golden is branch-agnostic.
- The same BE fix is proposed on master in #70365.
Local status: the new case and the existing `test_variant_cast` /
`test_variant_cast_strict_mode` pass on a 4.2 build; the 4.1 golden of
`test_variant_cast_nullable` is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
