OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4470183888
##########
be/src/core/data_type_serde/data_type_varbinary_serde.cpp:
##########
@@ -284,11 +319,11 @@ Status
DataTypeVarbinarySerDe::read_column_from_arrow(IColumn& column,
return Status::OK();
}
-Status DataTypeVarbinarySerDe::write_column_to_orc(const std::string& timezone,
- const IColumn& column,
const NullMap* null_map,
- orc::ColumnVectorBatch*
orc_col_batch,
- int64_t start, int64_t end,
Arena& arena,
- const FormatOptions&
options) const {
+template <typename ColumnType>
Review Comment:
Fixed in e993d2e9d03. Both spatial ORC SerDe entry points now return
NotSupported before the invalid cast, preserving Parquet-only support. Added
both-kind and nullable regression coverage; 45 related BE tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
