abhinav-phi commented on PR #68731: URL: https://github.com/apache/doris/pull/68731#issuecomment-6717131248
@morrySnow could you take a final look at 8da19ea9? your approval from 9 oct was dismissed by the push that carried the fixes, so this has been sitting without a verdict since. the four bot findings from 9 oct were raised against the old head 35eca0a4 and are addressed in 8da19ea9: the rounding threshold no longer adds 0.5, and signed zero now agrees with the backend through equals, compareTo and computeHashCode on DoubleLiteral, FloatLiteral and NumericLiteral. the bot review still points at the pre-fix head, so it reads as unresolved even though the code changed. if something still blocks it, tell me what and i will fix it in one pass rather than another round of single items. if it is fine, a fresh +1 is all it needs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
