morningman commented on PR #69392:
URL: https://github.com/apache/doris/pull/69392#issuecomment-6619300037
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69392
commit: c8d917291673e51cea99c571dd329aab21e2bf25
base: 8e10b235cf030d486b6840cfd64b6218ab515e6d
reviewed_at: 2026-11-04T08:40+08:00
reviewer: morningman
model: claude-opus-5-5
effort: max
findings: {blocker: 0, major: 0, minor: 2, nit: 5}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-01 (wording, undeclared behaviour change)
`fe/fe-core/src/main/java/org/apache/doris/qe/QeProcessorImpl.java:361-365`:
since c8d91729167, FE cancels the coordinator whenever it rejects a final
external-file report. This applies to Hive, Iceberg, MaxCompute and Paimon
alike. A statement that used to hang until `insert_timeout` now fails at once
and carries the reason. The change is correct, and no statement that would have
succeeded can fail because of it. But the PR body does not declare it, and its
line 47 still credits BE's cancel. Worth fixing before the squash merge.
- Backport (`dev/4.1.x`, `dev/4.2.x`): only the BE half picks as is.
branch-4.1/4.2 plan Iceberg writes through fe-core `IcebergTransaction` and the
legacy `planner/Iceberg*Sink`. Neither branch has the fe-connector-iceberg
write path or the `rejectedExternalFileReport` ack handling in
`QeProcessorImpl`. So the FE commit-location gate
(`fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergConnectorTransaction.java:660-671`)
and the cancel have to be re-done there.
- Not verified by this review: nothing was built or run. CI at this head
passed every new BE/FE case and `test_iceberg_write_file_locations`. The red
`check_coverage_fe` is the exit-4 infra failure seen across PRs. No real OSS or
Azure storage was exercised.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
