yiguolei commented on PR #70428:
URL: https://github.com/apache/doris/pull/70428#issuecomment-6761131481
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70428
commit: b7d4150c8802224710d65dc8d9c520f2f1bb6e9d
base: 08231e3a6359082264c88e6fe2c8050e911e5236
reviewed_at: 2026-11-10T14:55+08:00
reviewer: yiguolei
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/src/format/format_common.h:105` — Reviewed shared lifetime,
erase/create interleavings, first publication, losing-candidate destruction,
and all six production consumers. Concurrent misses intentionally duplicate
I/O/allocations; retained-index/key accounting remains with the publisher.
- `be/src/exec/operator/file_scan_operator.h:117` — The cache is owned by
one query scan node and shared across its BE instances/scanners. No production
KVCache erase caller was found; utility lifetime tests do not establish a
production eviction incident.
- `be/test/format/format_common_test.cpp:31` — Static review only: builds,
unit/regression tests, sanitizers and benchmarks were not run. Ten utility
tests and relevant existing format tests were inspected; dedicated
throwing-factory, reentrant-destructor and same-key format integration tests
would strengthen coverage.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
