bobhan1 opened a new pull request, #70455:
URL: https://github.com/apache/doris/pull/70455

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: #70218
   
   Backport #70218 (`08231e3a6359082264c88e6fe2c8050e911e5236`) to `branch-4.2`.
   
   Completed committed-rowset notifications retain task signatures, and 
consumed empty-rowset markers remain cached. Release signatures on every 
callback exit and give empty and non-empty rowsets the same removal and 
expiration lifecycle. Enable the existing FE/BE notification settings by 
default, disable forced initial MoW rowset synchronization by default, and 
remove the six redundant Cloud p0/p1 configuration overrides.
   
   ### Branch-specific adaptations
   
   - Keep the existing 4.2 configuration layout. Random segment IDs and Table 
Stream settings from master are outside this backport.
   - Omit the fixture-only update to `CloudGroupRowsetBuilderWriterTest`: that 
test and its corresponding feature are absent from `branch-4.2`. The 
notification and cache regression tests are identical to the upstream versions.
   
   ### Testing
   
   - `./run-fe-ut.sh --run 
org.apache.doris.cloud.transaction.CloudGlobalTransactionMgrTest`: 33 tests 
passed, 0 failures/errors/skips; Maven `BUILD SUCCESS`.
   - `./run-be-ut.sh --run 
--filter='CloudCommittedRSMgrTest.*:EnabledAndDisabled/CloudCommittedRowsetTaskTest.*:TaskWorkerPoolTest.*:CloudTabletApplyVisiblePendingTest.*:*DeltaWriterCancelTest.*'
 -j100`: 44 ASAN tests passed, including both enabled/disabled 
signature-release cases, empty-rowset removal, expiration refresh, 
pending-rowset visibility, and local/cloud cancellation.
   - Clang-format v16 passed for all six changed C++ files.
   - Verified that all six removed pipeline overrides equal the new defaults 
and that all other parsed settings remain unchanged.
   - `git diff --check upstream/branch-4.2...HEAD` passed.
   - Cloud end-to-end regression and a standalone production BE build were not 
run.
   
   ### Release note
   
   Cloud committed-rowset notifications now default to enabled: FE 
`enable_notify_be_after_load_txn_commit=true` and BE 
`enable_cloud_make_rs_visible_on_be=true`. Completed notifications release 
their task signatures, and consumed empty-rowset entries are removed promptly. 
BE `cloud_mow_sync_rowsets_when_load_txn_begin` now defaults to `false`.
   
   The original PR's behavior and upgrade considerations apply: skipping 
initial synchronization can enlarge the existing local-snapshot freshness 
window. During rolling upgrades, keep FE notifications disabled until all 
receiving BEs contain the signature-cleanup fix.
   
   ### Check List (For Author)
   
   - Test: targeted BE/FE unit tests and configuration checks described above.
   - Behavior changed: Yes; the three configuration defaults change as 
described above.
   - Does this need documentation: Yes; the default changes should be reflected 
in configuration documentation and release notes.
   
   ### AI Disclosure
   
   - Tool: Codex (GPT-6).
   - Backport conflict resolution and this description were prepared with AI 
assistance; the implementation originates from #70218.
   - Human review: Pending.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to