liaoxin01 commented on PR #70443: URL: https://github.com/apache/doris/pull/70443#issuecomment-6795612650
1. Keep ObjStorageClientFactory focused on caching and reuse. Move AWS settings and SDK lifetime management into a shared AWS module. 2. Use provider-specific configuration types, composing common settings instead of putting every provider’s parameters into one S3-centric config. 3. Move provider-specific construction into each client’s create() method and remove the extra builder layer. 4. Keep naming consistent with ObjStorageClient; mixing ObjStorage*, Storage*, factories, and builders makes the responsibilities unclear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
