mrhhsg commented on PR #70474:
URL: https://github.com/apache/doris/pull/70474#issuecomment-6813884302
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70474
commit: 0321a0681b4bc9a3ea5342c15aece89e64203ddb
base: 1f241cf9b451730d06fc2edbba89bef27ba4efda
reviewed_at: 2026-11-12T11:51+08:00
reviewer: mrhhsg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-01 (test-coverage, Regression: yes, Minor)
`be/src/exec/spill/spill_file_manager.cpp:514` — Query teardown now only
enqueues; the external-session test releases its lease before the first
explicit GC, so its old live-lease negative coverage is lost. Run GC before
releasing the session and assert the file/pending entry survives. Minor is
acceptable for the new-finding verdict because the production lease guard
remains intact; no current early deletion/data-loss defect was demonstrated.
This is static review; no tests were run here.
- Existing comment 4545962271
(https://github.com/apache/doris/pull/70474#discussion_r4545962271) already
reports `be/src/exec/spill/spill_file.cpp:92` normal-cleanup O(N^2) enqueue
under the pending-directory mutex. Independently confirmed and still present at
this head; deduplicated rather than re-raised. This run's APPROVE applies only
to new findings and does NOT mark that known performance regression resolved or
override its thread.
- `be/src/exec/spill/spill_file.cpp:76` — Only physical cleanup is
asynchronous. Unfinished writer discard remains synchronous and may wait for
uploads. No real object-storage E2E, benchmark, SQL regression or mixed-version
execution was performed by this review.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
