CalvinKirs commented on PR #66115:
URL: https://github.com/apache/doris/pull/66115#issuecomment-6819753912
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#66115
commit: 51430482b0bde7a2fb1c74726b3b529aac162ae0
base: e125ea858678fd2aea5ebf179359650aa77fabb6
reviewed_at: 2026-11-12T17:22+08:00
reviewer: CalvinKirs
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 1}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Password.java:26-28`
— One inherited Nit remains: the lifetime comment (also in
DualPasswordTest.java:65-67) says an ordinary password change removes the
secondary, while the implementation and tests preserve it. No new finding in
this review.
- All 92 FE Maven reactor modules passed local Checkstyle validation across
the initial 74 modules and a heap-limited resume of the remaining 18. No
unit/regression, live-cluster, old-FE or failover tests were run locally;
buildall was requested separately.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
