924060929 commented on PR #70398: URL: https://github.com/apache/doris/pull/70398#issuecomment-6821624286
### Local follow-up review — ✅ PASS <!-- db-object-eviction-followup:4dd904ad0a7e74f9ed416cd0cda93e31de6fa3f2 --> Commit: `4dd904ad0a7e74f9ed416cd0cda93e31de6fa3f2`. When an MV plan resolves two external databases with a one-entry database object cache, eviction used to report a semantic database change. That invalidated the rewrite generation of every successful build and caused unlimited reconstruction. - Automatic object eviction now retains typed engine cleanup without reporting a metadata change. Explicit invalidations retain SQL/MV notifications and row-count fencing. - Rewrite-cache construction is bounded to four attempts. If metadata keeps changing, the existing callers catch the analysis failure and skip the optional MV optimization. - Added a reproduction using the real size-limited database MetaCache and fresh StatementContext table lookups, with capacity one and two as controls; automatic/explicit removal causes and both MV cache variants are covered. - Validation: 192 focused FE tests across 14 classes passed, with zero failures/errors/skips. `./build.sh --fe` passed with integrated Checkstyle; UI generation was disabled. - Focused local review: one reviewer, one clean pass over the seven files changed by this repair, including generation publication, callback routing, lock boundaries, failure isolation, both branch-native implementations and all production callers. No additional P1/P2 found in this repair scope. The original 4.1 reproduction failed six of eleven tests before the production fix. This is a focused repair receipt; remote CI and the newly triggered review remain separate gates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
