github-actions[bot] commented on code in PR #70263:
URL: https://github.com/apache/doris/pull/70263#discussion_r4562174096
##########
build-support/check-header-deps.py:
##########
@@ -689,40 +673,6 @@
"storage/index/ann/faiss_ann_index.h",
# The analysis layer (T3, T4, T8, T9).
"storage/index/inverted/analysis/analyzer/analyzer.cpp",
- "storage/index/inverted/analysis/analyzer/analyzer.h",
Review Comment:
[P2] Retarget the stale-exception probes when removing these entries
`build-support/tests/test-build-hygiene-header-deps.sh` still removes a
CLucene include from `pinyin_alphabet_tokenizer.h` (lines 137-146) and replaces
`lucene::` in `analyzer.h` (lines 162-171), then requires stale-whitelist
diagnostics for those exact headers. This PR removes both dependencies and
their whitelist entries, so both mutations become no-ops and the required
diagnostics cannot be emitted. Consequently the mandatory
`build-support/tests/run.sh` suite fails even on an otherwise clean tree.
Retarget both probes to remaining whitelist entries and update their
backup/restore paths and expected diagnostics in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
