yujun777 commented on PR #69896:
URL: https://github.com/apache/doris/pull/69896#issuecomment-6851954068
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69896
commit: b352751e678f173ebe8140c245029708ee2963f7
base: ccfd4378d424292a363a96142ad795b8c9ace21e
reviewed_at: 2026-11-13T19:48+08:00
reviewer: yujun777
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- Validation remains partial: cloud `changelog_p0` passed 24/28.
`test_changelog_before_column_name`, `test_cloud_changelog_publish_conflict`,
`test_changelog_multi_segment`, and `test_changelog_basic` failed again in
isolation on OP/before-image contents; their goldens are unchanged. Current
full review re-confirmed the inherited causal boundaries without substantiating
a PR-specific defect. No merge-base cluster comparison or exact `key_detail`
history-miss cause was established.
-
`regression-test/suites/changelog_p0/test_changelog_immediate_row_count.groovy:102-128`
now checks two successive load/consume rounds with periodic publication
paused: current changelog stock grows 2→3→4 and consumption leaves it
unchanged, each consumed range becomes empty, and the sink receives exactly the
two new rows. The extended suite passed once in SN and once in cloud.
- This review did not build or run tests. The new runs used existing
binaries reporting version `1f556`; that version string is not proof that every
final production file was built, and no exact `b352751` binary rebuild or
combined-companion-PR runtime result is claimed. The prior recovery fix retains
its separate inherited FE red/green evidence.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]