raghav-reglobe commented on PR #70554:
URL: https://github.com/apache/doris/pull/70554#issuecomment-6855056873
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70554
commit: 9bd2d00c09aade2837b9fda938c0dde14b71ce03
base: ccfd4378d424292a363a96142ad795b8c9ace21e
reviewed_at: 2026-11-13T19:28+05:30
reviewer: raghav-reglobe
model: claude-opus-5-5
effort: xhigh
findings: {blocker: 0, major: 0, minor: 4, nit: 5}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-06 (observability, behaviour change not declared at the reviewed commit;
the PR description now declares it)
`fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/InferAggNotNull.java:55-59`
— where a lower filter under the aggregate already holds an inferred not-null
(a nested CASE/IF without ELSE), the rule no longer adds a generated copy on
top, so one filter's conjunct order in plain EXPLAIN differs from the merge
base; predicates, plan shape and results are the same. Checked by reading, not
run.
- F-01
`fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/rewrite/TopDownVisitorRewriteJob.java:37-42`
— the rewrite bound covers the visitor job only; the other three drivers have
none, and a planner entry that never starts the statement stopwatch has no
planning timeout either, as before this PR.
- F-04
`fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/InferAggNotNullTest.java:131-192`
— no regression or end-to-end test runs the issue's statement, and neither new
rule test runs on the visitor driver.
- F-07
`fe/fe-core/src/test/java/org/apache/doris/nereids/jobs/rewrite/TopDownVisitorRewriteJobTest.java:128-134`
— the planning-timeout test depends on wall-clock time (a 1.1 s sleep); a
deterministic form exists.
- The same loop is on branch-4.0 and branch-4.1 (F-03); the PR description
names both and the two PRs that introduced the two halves.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
