raghav-reglobe commented on PR #70573:
URL: https://github.com/apache/doris/pull/70573#issuecomment-6871261881
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70573
commit: 8a371547fd64b49067d61f916ee5d1f1d7aa03b2
base: 89d4f2826e2c9edbba01f5f70fc1d243e89f17b5
reviewed_at: 2026-11-14T09:21+05:30
reviewer: raghav-reglobe
model: claude-opus-5-5
effort: xhigh
findings: {blocker: 0, major: 0, minor: 4, nit: 4}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-05 (observability, a behaviour change not declared at the reviewed
commit; the PR description now declares it)
`fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java:174-176`
— while a new task is held for lack of data, its own checks (the job's compute
group, and the data check that notices an unreachable broker) run at each look,
once per `max_batch_interval`, not on every pass; so an idle job is paused for
such a fault up to one interval later, and a fault that clears within the hold
does not pause it. No row is delayed or lost by it. Checked by reading, not run.
- F-01
`fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java:164-165`
— the wait also applies when a job's tasks are made again by an auto resume or
a change of the topic's partitions, and a new job starts at the end of its
topic by default, so any quiet topic gives the empty first look; the release
note did not name the cost (data that arrives after the first empty look loads
up to `max_batch_interval` later). The description and its release note are
corrected; the code comment still names three triggers only.
- F-02
`fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java:109-114`
— optional: a task held only for lack of data could be released from the job's
offset cache, which the job refreshes every 10 s, with no extra lookup; that
would cut the wait from one interval to about 10 s.
- F-03, F-04, F-08
`fe/fe-core/src/test/java/org/apache/doris/load/routineload/RoutineLoadTaskSchedulerTest.java:361-369`
— test gaps: no test runs the two production builders that set and carry
`lastScheduledTime == -1`, on which the fix keys; the "held pass does not move
the time" check can pass within one millisecond; no test runs the edited gate
with a task held by `isEof` or `delaySchedule`.
- F-06, F-07 — `close #70568` closes the issue while one case the
description names stays as it is (a task renewed after a commit that was not at
EOF still asks on every pass); and the new field's comment and one test name
describe a renewal of a marked task, which cannot occur, and say a commit
decides `delaySchedule`, which an abort renewal also sets.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
