csun5285 opened a new pull request, #70597:
URL: https://github.com/apache/doris/pull/70597

   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #68198 #68997
   
   Problem Summary:
   
   A short-circuit point query that reads a column added by light schema change 
fails until a load on the same BE carries the new schema there:
   
   ```sql
   CREATE TABLE t (k INT NOT NULL, v1 INT, v2 INT)
   UNIQUE KEY(k) DISTRIBUTED BY HASH(k) BUCKETS 1
   PROPERTIES ("replication_num" = "1", "enable_unique_key_merge_on_write" = 
"true",
               "light_schema_change" = "true", "store_row_column" = "true", 
"row_store_columns" = "k,v1");
   INSERT INTO t VALUES (1, 100, 1000);
   ALTER TABLE t ADD COLUMN v_default INT DEFAULT "777";
   SET enable_short_circuit_query = true;
   SET enable_short_circuit_query_access_column_store = true;
   SELECT k, v_default FROM t WHERE k = 1;
   -- before: [INTERNAL_ERROR]field name is invalid. field=v_default, 
field_name_to_index=[...]
   -- after:  1  777
   ```
   
   Root cause: the lookup request carries no schema, so when the row store does 
not cover a column `PointQueryExecutor` reads it from the column store with 
`BaseTablet::_max_version_schema`. That schema only moves forward when the 
tablet object is created, when a load is initialised on this BE, or on an index 
change compaction. A light schema change writes nothing, and syncing rowsets 
written by another BE does not move it either, so a BE that only serves reads 
keeps the old schema for as long as the tablet object lives and every such 
query fails. A normal scan is not affected because it rebuilds its schema from 
the columns FE sends.
   
   Fix: when the column is not in the tablet schema, describe it from the slot 
(name, unique id, type, default value) and read the segment with that. A 
segment that holds the column answers with its value, one that does not answers 
with the default. `Schema::tablet_column_from_slot` builds the sub columns of 
ARRAY / MAP / STRUCT as well; without them a default iterator for such a column 
aborts the BE. The error raised when the column store fallback is disabled now 
names the column from the slot instead of `column_by_uid`, which throws on an 
unknown uid, and `tablet_fetch_data` catches exceptions so a throwing point 
query returns an error.
   
   This is the point query part of #68198 and #68997 on master, without the 
read path refactor around it.
   
   ### Release note
   
   Fix short-circuit point query failing with "field name is invalid" on a 
column added by light schema change.
   
   ### Check List (For Author)
   
   - Test: Regression test / Unit Test / Manual test
       - Regression test: point_query_p0/test_point_query_light_schema_change, 
fails with the error above before the fix and passes after; the generated .out 
is identical to master's
       - Unit Test: StorageSchemaTest.TabletColumnFromSlot*
       - Manual test: local cloud cluster with two compute groups, one BE each. 
Create the table and load in group A, point query in group B, add the columns, 
then point query in group B: an old row, and a row group A loaded after the 
alter. Before the fix both fail in group B with the error above, also after the 
load in group A; after the fix the old row reads the defaults and the new row 
reads the values group A wrote
   - Behavior changed: No
   - Does this need documentation: No
   
   ### Background
   
   <!-- How the feature or module this PR touches works today, in two to four 
plain sentences, for a reviewer who doesn't know it. Link the user doc if there 
is one. Leave the problem and the fix to Problem Summary. -->
   
   ### What problem does this PR solve?
   
   <!-- Issue Number: "close #N" if this PR resolves the issue, "#N" if it only 
relates to it, "None" if there is none. A Feature needs an issue. -->
   <!-- Related PR: "#N (relation)" for each PR a reviewer should know about, 
such as "#123 (introduced the bug)", separated by commas. Write "None" if no 
related PR is known. -->
   <!-- PR Type: Bugfix, Performance, Feature, Enhancement, Refactor, Test, 
Build/CI/Chore, Revert, Release/Dependency, or Other. -->
   
   Issue Number:
   Related PR:
   PR Type:
   
   Problem Summary:
   
   <!-- Two to five sentences: the problem or need and who is affected; the 
approach in one sentence; when the diff is larger than that suggests, what else 
it had to handle, or that most of it is tests; and what existing users see 
after an upgrade. -->
   
   ### Details
   
   <!--
   For a diff of more than about 300 changed lines, start with "- **Change 
map:**": how many lines are production code, tests, generated files, and docs, 
then the code in parts, each with the problem it handles and its size.
   Then answer each field of your PR type on its own line, as "- **Field:** 
answer", in this order:
     Bugfix: Frequency, Root cause, Why existing tests missed it, Fix, Other 
paths and branches
     Performance: Why it was slow, Optimization, Results, Applicability and cost
     Feature: Scope, Design, Usage, Default behavior, Compatibility
     Enhancement: Before and after, Configs and defaults, Impact on existing 
users
     Refactor: Moves vs. logic changes, Behavior change, Compatibility, 
Performance impact, Rollback
     Test, adding tests: Scenarios, What existing tests miss, Fails when broken
     Test, fixing a test: Failure, Cause, Stability evidence
     Build/CI/Chore: Affected, Developer and release impact, License and 
third-party, Rollback
     Revert: Why not fix forward, Original author notified, Follow-up
     Release/Dependency: Versions, Upstream changes, Compatibility, Rollback
     Other: Why Other
   "None" is a valid answer when it is true. Don't restate the diff.
   -->
   
   ### Testing
   
   <!-- The tests, suites, or commands that ran, what each shows, and where it 
ran (locally or in CI). For a fix, the test that fails before it and passes 
after. -->
   
   ### Notes for Reviewers
   
   <!-- Optional; delete this section if there is nothing to say. Why each 
non-obvious edit was made, what you are unsure about, and where to start 
reading if Details has no Change map. -->
   
   ### Release note
   
   <!-- One paragraph on what users will notice, or None. -->
   
   ### Check List (For Author)
   
   <!-- Behavior changed: "No", or "Yes (see Details)" with a Behavior change 
field in Details. -->
   <!-- Does this need documentation: "No", or "Yes" with the 
apache/doris-website PR or the plan. -->
   <!-- Pre-submission status: "Ready"; "Partially verified: " and what is not 
verified; or "Not ready: " and why, for a Draft PR. -->
   
   - Behavior changed:
   - Does this need documentation:
   - Pre-submission status:
   
   ### AI Disclosure
   
   <!-- Tool: the agent and model, or None. Generated: the parts it wrote 
(code, tests, this description), or None. Human review: what you reviewed of 
the generated parts, or "Not applicable" without AI tools. You may add "- 
Prompts:" to summarize how you directed the agent. -->
   
   - Tool:
   - Generated:
   - Human review:
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to