hello-stephen opened a new pull request, #70605: URL: https://github.com/apache/doris/pull/70605
### Background PR comment commands use a shared TeamCity helper to verify the PR before submitting builds or writing file-filter skip statuses. ### What problem does this PR solve? Issue Number: None Related PR: #70459 (introduced the draft restriction), #70515 (retained it) PR Type: Bugfix Problem Summary: Authorized `run buildall` and individual commands fail on open draft PRs, including when a lane should only write a skip status. Allow draft PRs through the shared gate while retaining the open-state, exact head and target-branch checks. ### Details - **Frequency:** Every comment-triggered build or skip for a draft PR. - **Root cause:** The common PR identity check also required `draft == false`. - **Why existing tests missed it:** Existing dispatch tests replaced the PR check with a freshness stub. - **Fix:** Remove only the draft predicate. New tests exercise the real PR predicate for both enqueue and skip paths. - **Other paths and branches:** The shared helper covers all supported comment-triggered lanes and branches. Workflow commenter authorization and file filters are unchanged. ### Testing - `python3 regression-test/pipeline/common/tests/test_teamcity_utils.py`: 29 tests passed locally. - The new draft acceptance test fails against the original predicate. - Negative coverage verifies closed PRs, changed heads and changed target branches cannot enqueue builds or write skip statuses. - `bash -n regression-test/pipeline/common/teamcity-utils.sh` and `git diff --check` passed. - No live CI rerun performed for this change. ### Release note None. ### Check List (For Author) - Behavior changed: Yes (open draft PRs accept authorized comment triggers). - Does this need documentation: No. - Pre-submission status: Ready. ### AI Disclosure - Tool: OpenAI Codex. - Generated: Code change, tests and PR description. - Human review: Pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
