eldenmoon opened a new pull request, #70639:
URL: https://github.com/apache/doris/pull/70639

   ### Background
   
   VARIANT tables with escaped dotted keys reject NestedGroup columns. The 
parser only applies the test-only `default_variant_*` session variables when 
debug points are enabled.
   
   ### What problem does this PR solve?
   
   Issue Number: None
   Related PR: #70501 (added the debug-point gate for VARIANT session defaults)
   PR Type: Test
   
   Problem Summary:
   
   `VariantEscapeTableTest.testNestedGroupFinalTypeIsForbidden` sets the 
NestedGroup session default without enabling debug points. The parser therefore 
uses the built-in default, creates the table, and the expected-exception 
assertion fails. Enable debug points for the session-default case and restore 
both the original configuration and session value in `finally`.
   
   ### Details
   
   - **Failure:** The original test fails at the `nested_default` CREATE TABLE 
assertion with "Expected java.lang.Exception to be thrown, but nothing was 
thrown."
   - **Cause:** The test did not enable the debug-point gate introduced by 
#70501.
   - **Stability evidence:** The failure was reproduced on master before the 
change. After the change, the complete test class and the adjacent parser and 
CREATE TABLE LIKE test classes pass. Both modified values are restored even if 
the assertion fails.
   
   ### Testing
   
   On the remote Linux development worktree:
   
   - Before the fix: `./run-fe-ut.sh --run 
org.apache.doris.catalog.VariantEscapeTableTest#testNestedGroupFinalTypeIsForbidden`
 fails at the expected-exception assertion.
   - After the fix: `./run-fe-ut.sh --run 
org.apache.doris.catalog.VariantEscapeTableTest,org.apache.doris.catalog.CreateTableLikeTest,org.apache.doris.nereids.parser.NereidsParserTest`
 passes all 115 tests (9 + 14 + 92), with no failures, errors, or skips.
   - `PATH=~/agent-bin:$PATH build-support/clang-format.sh` completes 
successfully.
   - `mvn checkstyle:check -pl fe-core` reports 0 violations.
   
   ### Release note
   
   None.
   
   ### Check List (For Author)
   
   - Behavior changed: No
   - Does this need documentation: No
   - Pre-submission status: Ready
   
   ### AI Disclosure
   
   - Tool: OpenAI Codex
   - Generated: Test fix and PR description.
   - Human review: Not yet performed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to