eldenmoon commented on PR #70622:
URL: https://github.com/apache/doris/pull/70622#issuecomment-6936951490
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70622
commit: 066432afc86cfde8db4d5c0cc818d8c456056f5b
base: e1ed017a6c25c70c5199d23eb390e0442291e5f8
reviewed_at: 2026-11-17T10:37+08:00
reviewer: eldenmoon
model: gpt-6
effort: unverified
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: false
```
**Notes for maintainers**
- Reviewed both changed files: `be/src/cloud/pb_convert.cpp` and
`be/test/storage/pb_convert_test.cpp`. No blocking correctness, compatibility,
performance, or maintainability issues identified.
- Both Doris-to-Cloud and Cloud-to-Doris conversions preserve the presence
semantics of `variant_escape_dots_in_keys` across const-reference and rvalue
overloads. Absent fields remain absent; explicitly set `true` and `false`
values remain unchanged.
- Backward compatibility is preserved for legacy schemas that omit this
optional field. No protobuf definition, storage format, or effective
default-value changes are introduced.
- Regression tests cover absent and explicitly set values across both
conversion directions and copy/move paths. The author reports 42 passing unit
tests; no independent local builds or tests were run.
- The pointer-output overloads assume normal conversion usage with fresh
destination protobuf objects. Reusing an already-populated destination could
retain stale optional-field presence, but no production regression was
established in the reviewed call paths.
<sub>Static review following the `doris-repo-review` checklist. This is not
a verified pipeline-equivalent PASS receipt and does not represent a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]