morningman commented on PR #70523:
URL: https://github.com/apache/doris/pull/70523#issuecomment-6941364527
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70523
commit: 6e329402e43bab19b79d390acf681ef239edfb13
base: c298259d425b0418568bc8f25bbb397dd34b1e16
reviewed_at: 2026-11-17T15:11+08:00
reviewer: morningman
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 2}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-01 (wording):
`fe/fe-core/src/main/java/org/apache/doris/catalog/TableIf.java:342` changes
SQL ENGINE and plan JSON as intended. Correct the PR description's REST
`tableType` claim: the live schema endpoint still derives `engineType` from the
unchanged enum; the engine-based helper has no callers.
- F-02 (maintainability):
`regression-test/suites/mtmv_p0/test_mtmv_engine_name.groovy:57` correctly
checks SHOW output, but deterministic Name/Engine fields should use
`quickRunTest` row conversion and a generated `.out` baseline under the
repository convention.
- Static review only; no builds or tests were run during this review. No
undeclared runtime regression was substantiated.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]