yiguolei commented on PR #70479:
URL: https://github.com/apache/doris/pull/70479#issuecomment-6941681188

   Scoped follow-up review of commit `87ee1c9fb2b45820a9375d3f4cfafcaf46c0a374`.
   
   At the author's request, this follow-up excludes the previously identified 
`dim="+3"` Group Commit compatibility case and full-row DELETE of generated ANN 
columns. These are scope exclusions, not fixes verified in this commit; 
generated-column handling is being addressed separately.
   
   I rechecked ANN validation failure cleanup and shared-queue isolation, 
schema/prepared-plan reuse, ordinary ANN DELETE full/partial transitions 
(including hidden/sequence columns and changelog dependencies), and regression 
request/status gates. **No additional blocking issues found within the agreed 
scope.**
   
   The previously noted test-style nit remains: deterministic SQL-result checks 
at [lines 
49–51](https://github.com/apache/doris/blob/87ee1c9fb2b45820a9375d3f4cfafcaf46c0a374/regression-test/suites/ann_index_p0/ann_delete_group_commit.groovy#L49-L51)
 and [line 
113](https://github.com/apache/doris/blob/87ee1c9fb2b45820a9375d3f4cfafcaf46c0a374/regression-test/suites/ann_index_p0/ann_delete_group_commit.groovy#L113)
 should use `qt`/`order_qt` with runner-generated golden output under the 
repository convention. This is non-blocking.
   
   Static source review only; no builds or tests were run for this review. The 
conclusion applies only to the scope above and is not an unconditional PASS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to