uchenily opened a new pull request, #70688:
URL: https://github.com/apache/doris/pull/70688

   ### Background
   
   <!-- How the feature or module this PR touches works today, in two to four 
plain sentences, for a reviewer who doesn't know it. Link the user doc if there 
is one. Leave the problem and the fix to Problem Summary. -->
   
   ### What problem does this PR solve?
   
   <!-- Issue Number: "close #N" if this PR resolves the issue, "#N" if it only 
relates to it, "None" if there is none. A Feature needs an issue. -->
   <!-- Related PR: "#N (relation)" for each PR a reviewer should know about, 
such as "#123 (introduced the bug)", separated by commas. Write "None" if no 
related PR is known. -->
   <!-- PR Type: Bugfix, Performance, Feature, Enhancement, Refactor, Test, 
Build/CI/Chore, Revert, Release/Dependency, or Other. -->
   
   Issue Number: #70687 
   Related PR:
   PR Type: Bugfix
   
   Problem Summary:
   
   <!-- Two to five sentences: the problem or need and who is affected; the 
approach in one sentence; when the diff is larger than that suggests, what else 
it had to handle, or that most of it is tests; and what existing users see 
after an upgrade. -->
   
   When CSE virtual columns are used with Storage Top-N on tablets containing 
overlapping segments, a
    ColumnNothing placeholder can escape the segment iterator and reach a merge 
iterator. The iterator then casts
    it to the actual column type, causing a BE crash with Bad cast from 
type:doris::ColumnNothing to
    doris::ColumnVector. This PR confines virtual-column placeholders to 
segment iterators, materializes virtual
    columns explicitly where needed.
   
   ### Details
   
   <!--
   For a diff of more than about 300 changed lines, start with "- **Change 
map:**": how many lines are production code, tests, generated files, and docs, 
then the code in parts, each with the problem it handles and its size.
   Then answer each field of your PR type on its own line, as "- **Field:** 
answer", in this order:
     Bugfix: Frequency, Root cause, Why existing tests missed it, Fix, Other 
paths and branches
     Performance: Why it was slow, Optimization, Results, Applicability and cost
     Feature: Scope, Design, Usage, Default behavior, Compatibility
     Enhancement: Before and after, Configs and defaults, Impact on existing 
users
     Refactor: Moves vs. logic changes, Behavior change, Compatibility, 
Performance impact, Rollback
     Test, adding tests: Scenarios, What existing tests miss, Fails when broken
     Test, fixing a test: Failure, Cause, Stability evidence
     Build/CI/Chore: Affected, Developer and release impact, License and 
third-party, Rollback
     Revert: Why not fix forward, Original author notified, Follow-up
     Release/Dependency: Versions, Upstream changes, Compatibility, Rollback
     Other: Why Other
   "None" is a valid answer when it is true. Don't restate the diff.
   -->
   
    - Frequency: Deterministic when CSE virtual columns, Storage Top-N, and 
overlapping segments are combined.
    - Root cause: ColumnNothing crossed the storage iterator boundary and was 
consumed as a concrete typed
      column.
    - Why existing tests missed it: Existing tests did not cover default-sized 
write buffers, naturally generated
      overlapping segments, delete predicates, and both virtual-column and 
SELECT * Top-N plans together.
    - Fix: Keep ColumnNothing internal to SegmentIterator, initialize consumer 
blocks with real column types, and
      explicitly materialize virtual columns where needed.
    - Other paths and branches: Covers merge iterators, Storage Top-N, point 
queries, EOF, empty-result, and
      exception paths.
    - Behavior change: No intentional SQL behavior change; affected queries now 
return results instead of
      crashing the BE.
   
   ### Testing
   
   <!-- The tests, suites, or commands that ran, what each shows, and where it 
ran (locally or in CI). For a fix, the test that fails before it and passes 
after. -->
   
   ```
   ./run-regression-test.sh --run \
          -f 
regression-test/suites/query_p0/virtual_slot_ref/topn_virtual_slot_on_overlapping_segments.groovy
 \
          -genOut
   ```
   
   ### Notes for Reviewers
   
   <!-- Optional; delete this section if there is nothing to say. Why each 
non-obvious edit was made, what you are unsure about, and where to start 
reading if Details has no Change map. -->
   
   ### Release note
   
   <!-- One paragraph on what users will notice, or None. -->
   
   ### Check List (For Author)
   
   <!-- Behavior changed: "No", or "Yes (see Details)" with a Behavior change 
field in Details. -->
   <!-- Does this need documentation: "No", or "Yes" with the 
apache/doris-website PR or the plan. -->
   <!-- Pre-submission status: "Ready"; "Partially verified: " and what is not 
verified; or "Not ready: " and why, for a Draft PR. -->
   
   - Behavior changed:
   - Does this need documentation:
   - Pre-submission status:
   
   ### AI Disclosure
   
   <!-- Tool: the agent and model, or None. Generated: the parts it wrote 
(code, tests, this description), or None. Human review: what you reviewed of 
the generated parts, or "Not applicable" without AI tools. You may add "- 
Prompts:" to summarize how you directed the agent. -->
   
   - Tool: Codex
   - Generated:
   - Human review: Reviewed the affected storage paths, regression SQL, 
generated output, and local test results.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to