Gabriel39 commented on code in PR #70675:
URL: https://github.com/apache/doris/pull/70675#discussion_r4600174501


##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/ManifestCacheValue.java:
##########
@@ -43,10 +43,14 @@ public class ManifestCacheValue {
     private final List<DataFile> dataFiles;
     private final List<DeleteFile> deleteFiles;
     private final MetaCacheSizeEstimate sizeEstimate;
+    private final boolean cacheable;
 
     private ManifestCacheValue(List<DataFile> dataFiles, List<DeleteFile> 
deleteFiles, boolean estimateWeight) {
         this.dataFiles = dataFiles == null ? Collections.emptyList() : 
dataFiles;
         this.deleteFiles = deleteFiles == null ? Collections.emptyList() : 
deleteFiles;
+        // SDK file-key metadata contains the plaintext key, even when the 
enclosing manifest is plaintext.
+        this.cacheable = this.dataFiles.stream().noneMatch(file -> 
file.keyMetadata() != null)

Review Comment:
   Fixed in 7c04a372b900. Query-local partition projections now carry the 
source retention decision, since adaptation delegates key metadata unchanged. 
Four new data/delete cases first reproduced eager evaluation (five or two 
partition reads before consumption, instead of one), then passed after the fix. 
The full connector cache, SPI and Iceberg suites ran 2,342 tests with zero 
failures/errors and 11 existing skips; FE Checkstyle passed. The update also 
keeps cancellation-fixture manifest counts stable on hosts with many SDK 
workers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to