morningman opened a new pull request, #70695:
URL: https://github.com/apache/doris/pull/70695

   ### Background
   
   Doris maintainers use CODEOWNERS and past review activity to find people 
familiar with a PR's code. The existing Code Review Runner already provides 
Codex installation and a shared login pool for CI automation.
   
   ### What problem does this PR solve?
   
   Issue Number: None
   Related PR: None
   PR Type: Build/CI/Chore
   
   Problem Summary:
   
   Maintainers need a consistent way to select and contact reviewer candidates. 
Applying `need-reviewers` runs Codex with module-routing guidance, adds at most 
two candidates as assignees, posts a mention comment, and replaces the label 
with `reviewers-assigned`. Removing and reapplying the request label triggers a 
fresh selection; retrying the same run recovers its original selection. Most of 
the diff is a frozen mapping derived from 4,645 merged PRs across 57 modules, 
with explicit reviewer lists for Trino, Fluss, MongoDB and memory management. 
Automation starts after merge to the default branch and runs only for the 
request label.
   
   ### Details
   
   - **Change map:** All 58,598 added lines are CI/tooling: 56,251 lines of 
JSON routing evidence and taxonomy, 691 lines of guides, 718 lines of tests, 
353 lines of workflow and 585 lines of Python tooling. Routing/classification 
supports both an offline planner and the Action; the assignment helper 
validates selections and recovers partial GitHub updates. Raw research records 
remain local and are excluded.
   - **Affected:** A new GitHub Actions workflow on Ubuntu 24.04, Python, 
GitHub CLI and the existing pinned Codex 0.166.0 package. Doris runtime and 
build components are unchanged.
   - **Developer and release impact:** Maintainers can select candidates 
through a label or use the offline planner. The Action adds assignees and a 
review-request comment; it does not create formal review requests. No release 
steps change.
   - **License and third-party:** New Python files carry Apache headers. Codex 
and ossutil acquisition follows the existing runner, including pinned Codex 
checksums. No lockfile, LICENSE or NOTICE updates are needed.
   - **Rollback:** Revert this PR. Previously posted comments, assignees and 
labels can be adjusted through GitHub.
   - **CI permissions and secrets:** Selection uses `contents: read` and 
`pull-requests: read`; a separate assignment job adds `issues: write` for 
assignees, comments and labels. Both use the built-in `GITHUB_TOKEN`; existing 
`OSS_AK`, `OSS_SK` and the numbered Codex auth pool are reused. Only trusted 
default-branch files execute. Codex receives no GitHub write token, and 
artifacts exclude credentials and session logs.
   - **Behavior change:** Adding `need-reviewers` initiates routing even when 
`reviewers-assigned` already exists. Assignment and comment completion are 
verified before switching labels.
   
   ### Testing
   
   - `PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/scripts 
-p test_reviewer_assignment.py`: all 53 tests pass locally, covering 
eligibility, maintainer overrides, pagination, stale PR state, assignment 
failures, label reapplication and retry recovery.
   - Fourteen of these tests execute the actual auth-selection/sync shell 
blocks with fake OSS, covering cooldowns, invalid-token markers, credential 
replacement and refreshed-auth writeback.
   - All 53 tests also pass from an export containing only the CI 
sparse-checkout directories.
   - Hosted Actions execution, real Codex/OSS access and live GitHub mutations 
have not run.
   
   ### Notes for Reviewers
   
   The workflow reuses the existing credential pool without changing Code 
Review Runner. Concurrent credential replacement follows its snapshot-check 
behavior; no atomic lock across workflows is introduced. Maintainer overrides 
replace historical candidate pools while retaining author exclusion, live 
assignability checks and mapping expiry.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Behavior changed: Yes (see Details)
   - Does this need documentation: No
   - Pre-submission status: Partially verified: hosted Actions and Codex 
execution await deployment.
   
   ### AI Disclosure
   
   - Tool: Codex
   - Generated: Routing tool and mapping, workflow, tests, English guides and 
this description.
   - Human review: not stated
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to