costajohnt opened a new pull request, #70698:
URL: https://github.com/apache/doris/pull/70698

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: #50703
   
   Problem Summary:
   
   `test_minio_storage_vault` has two skip guards that only log and then fall 
through, so the case never skips. The MinIO guard also uses `enabled == null && 
enabled.equalsIgnoreCase("false")`, which throws a NullPointerException when 
`enableExternalMinioTest` is unset and is false in every other case. This PR 
returns from both guards and skips unless `enableExternalMinioTest` is true. It 
also sets `enableExternalMinioTest = true` in the vault_p0 pipeline config, 
which already starts the MinIO container and holds the `extMinio*` settings for 
this case, so the case keeps running there.
   
   ### Details
   
   - **Failure:** in any environment that reaches the guard with the flag 
unset, the suite fails with an NPE instead of skipping. With the default 
`enableExternalMinioTest = false`, it runs anyway and fails if no MinIO is 
reachable.
   - **Cause:** a missing `return` in both guards, and `&&` where the check 
needs `||` with a test for "true".
   - **Stability:** the vault_p0 pipeline keeps running the case, because its 
config now sets the flag. Other pipelines that load vault_p0 suites (p0, 
cloud_p0) still return at the `enableStoragevault()` guard as before.
   
   ### Testing
   
   I checked the guard against Doris's config loading path (ConfigSlurper, then 
`toProperties`, then `otherConfigs`) on Groovy 3.0.25 and 4.0.24. With the old 
guard, an unset flag throws an NPE and `false` runs the case. With the new 
guard, both skip, and the vault_p0 override (`true`) runs it. I have not run 
the suite against a cluster.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Behavior changed: No
   - Does this need documentation: No
   
   ### AI Disclosure
   
   - Tool: Claude Code
   - Generated: the code change and the PR description
   - Human review: the guard logic was checked by running it against Doris's 
config loading on Groovy 3 and 4; the full suite was not run on a Doris cluster.
   
   Found with [groovyfmt](https://github.com/costajohnt/groovyfmt), a Groovy 
formatter and linter.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to