Mryange opened a new pull request, #70707:
URL: https://github.com/apache/doris/pull/70707

   ### Background
   
   Doris uses jemalloc for memory allocation and heap profiling. BE and Cloud 
currently import its headers and static library from a separately prepared 
third-party package.
   
   ### What problem does this PR solve?
   
   Issue Number: None
   Related PR: None
   PR Type: Release/Dependency
   
   Problem Summary:
   
   Upgrading jemalloc currently requires updating the prebuilt third-party 
package as well as Doris. Build pinned jemalloc 5.3.1 through CMake 
ExternalProject, including checksum verification and the existing header patch, 
so the allocator upgrade travels with the Doris change. Remove the old 
thirdparty recipes while preserving allocation hooks and profiler settings.
   
   ### Details
   
   - **Change map:** 249 added and 110 removed lines: 276 lines of build/CI 
integration and recipe removal, 53 of test code, 24 of documentation and 6 of 
conditional production includes; the existing patch is moved unchanged.
   - **Versions:** jemalloc 5.3.0 → 5.3.1, official release archive pinned by 
SHA256 `3826bc80232f22ed5c4662f3034f799ca316e819103bdc7bb99018a421706f92`.
   - **Upstream changes:** Adopt the [5.3.1 maintenance 
release](https://github.com/jemalloc/jemalloc/releases/tag/5.3.1). The license 
is unchanged. No allocator tuning or performance claim is included.
   - **Compatibility:** Preserve the `je` prefix, static PIC library, 
allocation hooks, profiling, Linux GNU libunwind backend and ARM64 page-size 
option. Downloads and build artifacts stay inside each build directory; 
incremental builds reuse them. Builds with jemalloc disabled no longer require 
prebuilt jemalloc headers.
   - **Behavior change:** jemalloc upgrades to 5.3.1; allocator build moves 
from the prebuilt package into CMake. Production runtime settings remain 
unchanged.
   - **Rollback:** Revert the change and restore the matching prebuilt 5.3.0 
package. No stored-data format changes.
   
   ### Testing
   
   Validated on Linux x86_64:
   
   - BE DEBUG/ASAN, FE and Cloud DEBUG builds passed on the initial migration 
commit. BE and Cloud builds also passed with old prebuilt jemalloc 
headers/library moved out of lookup paths.
   - Actual BE symbols and disassembly confirmed malloc/free forward to 
jemalloc/jefree. Online profiling exported a heap profile; existing jeprof 
resolved Doris call stacks and 1,457,102 sampled bytes.
   - After switching to default download directories, two final hook-test runs 
passed 13/13 and reported `ninja: no work to do`. The profile test passed 20 
consecutive iterations with deterministic sampling.
   - Clang-format 16, build hygiene and changed-line clang-tidy passed on the 
migration; final shell syntax and whitespace checks passed.
   - Full builds were not repeated after the download-directory/test-launch 
adjustment. macOS/ARM64, full regression tests and Cloud service startup were 
not run. No performance comparison.
   
   ### Release note
   
   Upgrade jemalloc to 5.3.1. Doris builds the allocator through CMake without 
requiring an updated prebuilt third-party package.
   
   ### Check List (For Author)
   
   - Behavior changed: Yes (see Details: allocator version and build 
integration).
   - Does this need documentation: No (build README updated).
   - Pre-submission status: Partially verified: Linux x86_64 validated; 
macOS/ARM64 and full regression tests not run.
   
   ### AI Disclosure
   
   - Tool: Codex
   - Generated: Implementation, tests, build documentation and PR description.
   - Human review: Author discussed and approved the approach and reviewed the 
download-cache simplification; full line-by-line review was not stated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to