yiguolei commented on code in PR #70689:
URL: https://github.com/apache/doris/pull/70689#discussion_r4610226372


##########
be/src/storage/segment/column_reader_cache.cpp:
##########
@@ -135,7 +135,8 @@ Status ColumnReaderCache::get_column_reader(int32_t col_uid,
     } else {
         // For non-variant columns, we can create reader directly from 
ColumnMetaPB.
         VLOG_DEBUG << "insert cache: uid=" << col_uid << " col_id=" << 
meta.column_id();
-        RETURN_IF_ERROR(ColumnReader::create(opts, meta, _num_rows, 
_file_reader, &reader));
+        RETURN_IF_ERROR(ColumnReader::create_from_owned_meta(opts, 
std::move(meta), _num_rows,

Review Comment:
   We will not get some performance improvement because we have column reader 
cache.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to