yujun777 commented on PR #70561:
URL: https://github.com/apache/doris/pull/70561#issuecomment-6973852716
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70561
commit: 699780566be72387c25deab730556098f79bec62
base: 098d0bb62bbc82d9bd999d391efe1c20df89930b
reviewed_at: 2026-11-18T16:59+08:00
reviewer: yujun777
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/mtmv/ivm/IvmJoinDeltaHandler.java:666`
— Rebase retains upstream #70630 signed padding for the actual repair factor,
including computed -netCount; no no-argument call remains.
-
`fe/fe-core/src/main/java/org/apache/doris/mtmv/ivm/IvmJoinDeltaHandler.java:525`
— The immutable builder preserves detail-first children and the unique versus
pre/post repair order, with one UNION construction and unchanged output mapping.
-
`fe/fe-core/src/test/java/org/apache/doris/mtmv/ivm/IvmJoinDeltaHandlerTest.java:567`
— New coverage binds the actual net-count Slot inside the generated sequence
expression for both signs, LEFT/RIGHT/composite and BIGINT/LARGEINT; parity,
order, high bits and type are checked.
- Current evidence inspected: FE build, final compilation/Checkstyle, 156
distinct targeted FE tests and 3 normal regression suites passed. Prior
signed-sequence and empty-ANTI assumptions were refreshed against rebased
upstream; formal review itself was read-only.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]