github-actions[bot] commented on code in PR #17124:
URL: https://github.com/apache/doris/pull/17124#discussion_r1116920411
##########
be/src/vec/exec/format/json/new_json_reader.cpp:
##########
@@ -1303,27 +1304,49 @@ Status
NewJsonReader::_simdjson_handle_nested_complex_json(
return Status::OK();
}
+size_t NewJsonReader::_column_index(const StringRef& name, size_t key_index) {
+ /// Optimization by caching the order of fields (which is almost always
the same)
+ /// and a quick check to match the next expected field, instead of
searching the hash table.
+ if (_prev_positions.size() > key_index && _prev_positions[key_index] &&
+ name == _prev_positions[key_index]->get_first()) {
+ return _prev_positions[key_index]->get_second();
+ } else {
+ auto* it = _slot_desc_index.find(name);
+ if (it) {
+ if (key_index < _prev_positions.size()) {
+ _prev_positions[key_index] = it;
+ }
+ return it->get_second();
+ } else
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
e {
;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
