suxiaogang223 commented on PR #70566:
URL: https://github.com/apache/doris/pull/70566#issuecomment-6974519653
PASS — local Doris code-review completed for
`12b9cf5ccf0f00e0e3d50bbad03614b78dfdfd34` against
`098d0bb62bbc82d9bd999d391efe1c20df89930b`.
Fixed the stale Paimon table-generation finding by reusing retained-schema
validation before recovering runtime option overrides. Reviewed the full target
propagation, branch/schema binding, overwrite retries, plan copies, and
Paimon/Iceberg commit paths. Added real catalog-cache replacement coverage for
main/branch and INSERT/OVERWRITE, plus REST compatibility coverage. Also fixed
the missing Preconditions import and explicitly typed two existing Mockito
table-handle matchers after compilation exposed the new overload ambiguity. A
fresh review of this revision found no outstanding code-review findings.
All Part 1.3 checkpoints were reviewed: goal and scope; concurrency and
locks; lifecycle; configuration; compatibility; Thrift/Proto; parallel paths;
failure conditions; test coverage and result files; observability;
persistence/failover; write atomicity; FE-BE propagation; performance; and
other issues. No protocol or storage-format changes. Existing commit/failover
mechanisms are retained. Runtime fault injection is outside this static review.
Checkstyle and diff whitespace checks passed. The preceding local run passed
the complete SPI suite (166 tests), 123 Paimon and 110 Iceberg tests, and FE
production compilation. FE test compilation exposed the two Mockito matcher
ambiguities now fixed in this revision. The selected cases, including both
affected test classes, will be rerun; this PASS is the code-review result, not
a claim that all runtime validation is complete.
<!-- doris-repo-review:v1:begin -->
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70566
commit: 12b9cf5ccf0f00e0e3d50bbad03614b78dfdfd34
base: 098d0bb62bbc82d9bd999d391efe1c20df89930b
reviewed_at: 2026-11-18T09:30:36.712875+00:00
reviewer: suxiaogang223
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]