yujun777 commented on PR #69850:
URL: https://github.com/apache/doris/pull/69850#issuecomment-6980561214
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69850
commit: 2c47d99c7f454c0ab1edf639c84eae2ffbf9420f
base: ee73acc6131e6c6c752eb59e252404590be6ad77
reviewed_at: 2026-11-18T21:51+08:00
reviewer: yujun777
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/catalog/stream/StreamRowCountEstimator.java:87`
— Previous arithmetic finding resolved: retained positive BASE fallbacks and
wrapper totals saturate at the signed long limit, preserving unknown and
scan-mode semantics.
-
`fe/fe-core/src/main/java/org/apache/doris/catalog/stream/OlapTableStream.java:169`
— Consumption offset, sampled counts and durable source generation stay
together through local replay and authoritative MS readback; asynchronous
reports and TTL remain declared approximation limits.
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:430`
— Selected/unknown/temporary-partition and injected-column behavior, actual
snapshot MIN_DELTA and atomic selected-state coverage remain verified across
all 37 changed files.
-
`fe/fe-core/src/test/java/org/apache/doris/nereids/stats/StreamScanRowCountTest.java:417`
— The physical-plan and MAX+42 checks fail before the fix and pass afterward;
supplied current validation is 34 focused FE passes plus FE package/Checkstyle
success. Review ran no builds or tests.
- Earlier 42 in-memory ASAN Meta Service tests and 17 SN suites retain their
tested-head scopes; native/proto/golden bytes are unchanged. No new live Cloud
baseline-protocol/FDB/process-failover, combined companion runtime or benchmark
validation is claimed.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]