eldenmoon commented on code in PR #70408:
URL: https://github.com/apache/doris/pull/70408#discussion_r4623798063
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -5518,28 +5518,24 @@ public DataType
visitVariantPredefinedFields(VariantPredefinedFieldsContext ctx)
+ " is not supported when variant_enable_doc_mode
is true");
}
}
- } else {
- // When doc mode is disabled, clear doc mode specific settings
- variantDocMaterializationMinRows = 0;
- variantDocHashShardCount = 0;
}
if (!properties.isEmpty()) {
throw new NotSupportedException("only support for "
- +
PropertyAnalyzer.PROPERTIES_VARIANT_ENABLE_TYPED_PATHS_TO_SPARSE
- + " and " +
PropertyAnalyzer.PROPERTIES_VARIANT_MAX_SUBCOLUMNS_COUNT
+ + PropertyAnalyzer.PROPERTIES_VARIANT_MAX_SUBCOLUMNS_COUNT
+ " and " +
PropertyAnalyzer.PROPERTIES_VARIANT_MAX_SPARSE_COLUMN_STATISTICS_SIZE
+ " and " +
PropertyAnalyzer.PROPERTIES_VARIANT_SPARSE_HASH_SHARD_COUNT
+ " and " +
PropertyAnalyzer.PROPERTIES_VARIANT_ENABLE_DOC_MODE
- + " and " +
PropertyAnalyzer.PROPERTIES_VARIANT_DOC_MATERIALIZATION_MIN_ROWS
- + " and " +
PropertyAnalyzer.PROPERTIES_VARIANT_DOC_HASH_SHARD_COUNT
+ + " and " +
PropertyAnalyzer.PROPERTIES_VARIANT_SUBCOLUMN_EXTRACTION_MIN_ROWS
+ " and " +
PropertyAnalyzer.PROPERTIES_VARIANT_ENABLE_NESTED_GROUP);
}
return new VariantType(fields, variantMaxSubcolumnsCount,
enableTypedPathsToSparse,
- variantMaxSparseColumnStatisticsSize,
variantSparseHashShardCount,
- enableVariantDocMode, variantDocMaterializationMinRows,
variantDocHashShardCount,
- enableNestedGroup);
+ variantMaxSparseColumnStatisticsSize, enableVariantDocMode
? 0 : variantSparseHashShardCount,
Review Comment:
better show serialize version in properties when `show create table` for
seperating v1/v2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]