Gabriel39 commented on code in PR #70693:
URL: https://github.com/apache/doris/pull/70693#discussion_r4637845363


##########
be/src/exec/sink/writer/vtablet_writer.cpp:
##########
@@ -604,8 +604,12 @@ Status VNodeChannel::init(RuntimeState* state) {
     _row_desc = std::make_unique<RowDescriptor>(_tuple_desc);
     _batch_size = state->batch_size();
 
-    _stub = 
state->exec_env()->brpc_internal_client_cache()->get_client(_node_info.host,
-                                                                        
_node_info.brpc_port);
+    // Remote catalog writes retain the remote cluster's transport policy, 
independently of
+    // whether private RPC TLS is enabled in this cluster.
+    _stub = state->exec_env()->brpc_internal_client_cache()->get_client(
+            _node_info.host, _node_info.brpc_port,
+            _parent->_t_sink.olap_table_sink.remote_endpoint ? 
client::RpcPurpose::EXTERNAL_SERVICE

Review Comment:
   Mixed-version FE/BE rolling-upgrade compatibility is explicitly outside the 
requested scope of this PR. The supported activation procedure requires 
coordinated deployment/configuration and restart of the participating FE and BE 
nodes; the PR description now makes that boundary explicit. The same-version 
remote sink sets field 26, and no legacy-payload fallback is being added here. 
Resolving this as out of scope.



##########
fe/be-java-extensions/max-compute-connector/src/main/java/org/apache/doris/maxcompute/MaxComputeFeClient.java:
##########
@@ -203,12 +211,6 @@ private void sleepBeforeRetry() throws IOException {
         }
     }
 
-    private static TTransport createTransport(TNetworkAddress address, int 
timeoutMs,

Review Comment:
   This is already supported by f93e5d1c86d. The pinned Netty 4.2.18.Final 
file-based path first checks `BouncyCastleUtil.isBcPkixAvailable()` and calls 
`BouncyCastlePemReader.getPrivateKey(...)`: 
[SslContext.toPrivateKey](https://github.com/netty/netty/blob/netty-4.2.18.Final/handler/src/main/java/io/netty/handler/ssl/SslContext.java#L1240-L1259).
 The explicit [bcpkix 
dependency](https://github.com/apache/doris/blob/f93e5d1c86d18129b54115ea6d00f6a8a076fab7/fe/be-java-extensions/max-compute-connector/pom.xml#L65-L70)
 enables that reader; it does not require application code to call BC directly.
   
   The existing `nativeCompatiblePkcs1PrivateKeyCanAuthenticate` test writes an 
actual `RSA PRIVATE KEY` PEM and completes a real authenticated Thrift 
block-allocation RPC. It passed in the official FE test run (60 selected tests, 
including all nine MaxCompute TLS tests). I also reran the packaged-plugin 
probe after this comment: a fresh platform-parent class loader containing only 
the deployed MaxCompute plugin jars authenticated with PKCS#1 and reused the 
connection successfully. Removing bcpkix was separately verified to make the 
regression fail before the dependency fix.
   
   A second parser/conversion layer would duplicate the pinned Netty reader. 
Resolving this finding as a false positive; the negative 
certificate/hostname/timeout tests remain.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to