github-actions[bot] commented on code in PR #70659:
URL: https://github.com/apache/doris/pull/70659#discussion_r4637971948


##########
be/src/io/hdfs_builder.cpp:
##########
@@ -137,7 +138,16 @@ std::string HDFSCommonBuilder::get_hdfs_conf_value(const 
std::string& key,
 }
 
 void HDFSCommonBuilder::set_hdfs_conf_to_hdfs_builder() {
+    if (get_hdfs_conf_value(HADOOP_SECURITY_AUTHENTICATION, "simple") == 
"kerberos") {
+        // FE can expand core-default.xml's renewal=false into the incoming 
configuration.
+        // libhdfs prepends settings and replays them in reverse order: false 
then true
+        // would apply true then false. Resolve the map first and emit this 
key only once.

Review Comment:
   [P1] Apply the duplicate-key fix to the cloud recycler builder too. 
`cloud/src/recycler/hdfs_accessor.cpp` forwards `hdfs_confs` (which can contain 
`hadoop.kerberos.keytab.login.autorenewal.enabled=false`) at lines 127-128, 
then `check_krb_params()` appends `true` at lines 175-177. libhdfs replays 
duplicate settings in reverse insertion order, so the earlier false can remain 
effective and the storage-vault recycler loses automatic keytab renewal after 
the ticket lifetime. Resolve/overwrite this key before the cloud builder's 
configuration loop (or share the resolver) and cover the cloud path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to