github-actions[bot] commented on code in PR #70565:
URL: https://github.com/apache/doris/pull/70565#discussion_r4640834480


##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergCatalogOps.java:
##########
@@ -350,12 +350,13 @@ public List<String> listDatabaseNames() {
          */
         private List<String> listNestedNamespaces(Namespace parentNs) {
             SupportsNamespaces nsCatalog = (SupportsNamespaces) catalog;
-            if (restFlavor && nestedNamespaceEnabled) {
+            if (usesNestedNamespaces()) {
                 return nsCatalog.listNamespaces(parentNs).stream()
                         .flatMap(childNs -> {
                             try {
+                                String dbName = toDatabaseName(childNs);

Review Comment:
   [P2] Preserve stale-child handling before dotted-name validation. With a 
REST catalog using nested namespaces and external_catalog.name, 
listNamespaces(root) can return a child such as Namespace.of("root", "a.b") 
that is dropped before the recursive list. The new toDatabaseName(childNs) call 
at this line throws DorisConnectorException for the dotted level before 
listNestedNamespaces(childNs) can raise the NoSuchNamespaceException that the 
surrounding catch intentionally skips, aborting the whole database listing. 
Recurse/list the child first (or catch the stale namespace around conversion 
too), then reject dotted levels only for namespaces that still exist.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to