ZoruaSama opened a new pull request, #70824: URL: https://github.com/apache/doris/pull/70824
<!-- Recommended: develop the change with the develop-with-evidence skill and write this description with the doris-pr-description skill, both from https://github.com/apache/doris-skills (the doris-skills submodule of this repository). --> ### Background <!-- How the feature or module this PR touches works today, in two to four plain sentences, for a reviewer who doesn't know it. Link the user doc if there is one. Leave the problem and the fix to Problem Summary. --> `SUB_BITMAP` takes a slice of a bitmap's elements in ascending order. Positions start at zero, and negative positions count from the end, with `-1` selecting the last element. [SUB_BITMAP documentation](https://doris.apache.org/docs/4.x/sql-manual/sql-functions/scalar-functions/bitmap-functions/sub-bitmap/) ### What problem does this PR solve? <!-- Issue Number: "close #N" if this PR resolves the issue, "#N" if it only relates to it, "None" if there is none. A Feature needs an issue. --> <!-- Related PR: "#N (relation)" for each PR a reviewer should know about, such as "#123 (introduced the bug)", separated by commas. Write "None" if no related PR is known. --> <!-- PR Type: Bugfix, Performance, Feature, Enhancement, Refactor, Test, Build/CI/Chore, Revert, Release/Dependency, or Other. --> Issue Number: None Related PR: #13978 PR Type: Bugfix Problem Summary: <!-- Two to five sentences: the problem or need and who is affected; the approach in one sentence; when the diff is larger than that suggests, what else it had to handle, or that most of it is tests; and what existing users see after an upgrade. --> For a bitmap stored in the single-element representation, `SUB_BITMAP` returns `NULL` at offset `-1`. This fix lets the singleton branch select its sole element at offset `-1`. We can repro it with SQL as follows: ``` sql select bitmap_to_string(sub_bitmap(bitmamp_from_string('7'), -1, 1)); -- result: NULL -- expected: 7 ``` ### Details <!-- For a diff of more than about 300 changed lines, start with "- **Change map:**": how many lines are production code, tests, generated files, and docs, then the code in parts, each with the problem it handles and its size. Then answer each field of your PR type on its own line, as "- **Field:** answer", in this order: Bugfix: Frequency, Root cause, Why existing tests missed it, Fix, Other paths and branches Performance: Why it was slow, Optimization, Results, Applicability and cost Feature: Scope, Design, Usage, Default behavior, Compatibility Enhancement: Before and after, Configs and defaults, Impact on existing users Refactor: Moves vs. logic changes, Behavior change, Compatibility, Performance impact, Rollback Test, adding tests: Scenarios, What existing tests miss, Fails when broken Test, fixing a test: Failure, Cause, Stability evidence Build/CI/Chore: Affected, Developer and release impact, License and third-party, Rollback Revert: Why not fix forward, Original author notified, Follow-up Release/Dependency: Versions, Upstream changes, Compatibility, Rollback Other: Why Other "None" is a valid answer when it is true. Don't restate the diff. --> - **Frequency:** Always when the input uses the singleton representation, the offset is `-1`, and the limit is positive. - **Root cause:** `BitmapValue::offset_limit` handles singleton bitmaps before the common traversal paths. Its singleton branch accepted only offset `0`, so it returned zero selected elements for offset `-1`. `SUB_BITMAP` converts that result to SQL `NULL`. - **Why existing tests missed it:** The BE unit test `BitmapValueTest.sub_range_limit` checks singleton offsets `0` and `1`. The SQL regression suite `test_bitmap_function.groovy` checks a singleton at offset `0` and a larger bitmap at a negative offset. Neither tests a singleton at offset `-1`. - **Fix:** Accept offset `-1` alongside `0` in the singleton branch. The new unit test covers both valid offsets and verifies that `1` and `-2` select no elements. - **Other paths and branches:** The small-set and Roaring branches already translate negative offsets. The singleton check is also present on the locally fetched refs for `branch-3.1`, `branch-4.0`, `branch-4.1`, and `branch-4.2`. - **Behavior change:** A single-element bitmap sliced at offset `-1` with a positive limit now returns its element. ### Testing <!-- The tests, suites, or commands that ran, what each shows, and where it ran (locally or in CI). For a fix, the test that fails before it and passes after. --> - `bash run-be-ut.sh --run --filter=BitmapValueTest.offset_limit_singleton` passed on Apple Silicon macOS with ASAN (1 test). ### Notes for Reviewers <!-- Optional; delete this section if there is nothing to say. Why each non-obvious edit was made, what you are unsure about, and where to start reading if Details has no Change map. --> ### Release note <!-- One paragraph on what users will notice, or None. --> ### Check List (For Author) <!-- Behavior changed: "No", or "Yes (see Details)" with a Behavior change field in Details. --> <!-- Does this need documentation: "No", or "Yes" with the apache/doris-website PR or the plan. --> <!-- Pre-submission status: "Ready"; "Partially verified: " and what is not verified; or "Not ready: " and why, for a Draft PR. --> - Behavior changed: Yes (see Details) — a single-element bitmap sliced at offset `-1` with a positive limit now returns its element instead of `NULL`. - Does this need documentation: No - Pre-submission status: Partially verified. The SQL regression suite (`test_bitmap_function.groovy`) and the full BE UT set have not been run locally; relying on CI. ### AI Disclosure <!-- Tool: the agent and model, or None. Generated: the parts it wrote (code, tests, this description), or None. Human review: what you reviewed of the generated parts, or "Not applicable" without AI tools. You may add "- Prompts:" to summarize how you directed the agent. --> - Tool: None - Generated: None - Human review: Not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
