yiguolei commented on PR #70784:
URL: https://github.com/apache/doris/pull/70784#issuecomment-7050874665

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#70784
   commit: a644bcc25c326a913d7d41f390454e9668817da6
   base: 0a6b84b5a88b85f1cb5568b076bafe6ca7b01011
   reviewed_at: 2026-11-21T05:19+08:00
   reviewer: yiguolei
   model: gpt-6-astra
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - No actionable defects were found after reviewing both changed files and 
the surrounding schema lookup and HTTP test framework; the review converged in 
one round.
   - 
`fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/MetaInfoAction.java:247`:
 `isManagedTable()` selects the actual base index for async materialized views 
and matches the downstream proc lookup contract. `MTMV` extends `OlapTable`, so 
the cast remains valid.
   - `regression-test/suites/http_rest_api/get/test_async_mv_schema.groovy:41`: 
the new test checks the legacy HTTP route's application success code, base 
marker, and ordered view column aliases, rather than HTTP status alone.
   - The existing `with_mv` branch remains OLAP-only; this change fixes async 
materialized views' base schema lookup without extending secondary-index 
enumeration.
   - This was a static code review. No build, unit test, or regression test was 
run; the author's runtime validation was not independently reproduced.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to