github-actions[bot] commented on code in PR #70825:
URL: https://github.com/apache/doris/pull/70825#discussion_r4649581457


##########
gensrc/proto/olap_file.proto:
##########
@@ -200,6 +200,7 @@ message RowsetMetaPB {
     // Real segment ids in rowset position order. Empty means legacy 
continuous ids [0, num_segments).
     repeated int64 segment_ids = 200;
 
+    optional RowsetVariantDescSummaryPB variant_desc_summary = 201;

Review Comment:
   [P2] Preserve Variant summaries when cloning rowset metadata. Snapshot 
restore (CloudSnapshotMgr::_create_rowset_meta) and linked-file metadata 
construction (build_rowset_meta_with_spec_field) rebuild RowsetMetaPB from 
segment counts/IDs and bounds but never copy the new variant_desc_summary, even 
though they reuse the same segment files. Those rowsets then fail 
has_variant_desc_summary() and every extended-schema request falls back to 
reading all segment metadata, so the optimization disappears after restore or 
linked schema changes. Copy the summary when the source segment set is 
unchanged, retaining the count/ID invalidation rule.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to