github-actions[bot] commented on code in PR #70827:
URL: https://github.com/apache/doris/pull/70827#discussion_r4650579426


##########
fe/fe-connector/fe-connector-lance/src/main/java/org/apache/doris/connector/lance/LanceCatalogClient.java:
##########
@@ -127,6 +130,19 @@ LanceTableMetadata loadTableMetadata(String dbName, String 
tableName, OptionalLo
         });
     }
 
+    /**
+     * Reads the field ids and the user indexes of one table at the fixed 
{@code version}, for planning ranges
+     * over index segments.
+     */
+    LanceIndexMetadata loadIndexMetadata(String dbName, String tableName, long 
version) {

Review Comment:
   [P2] Keep the plugin TCCL installed through deferred native cleanup
   
   `loadIndexMetadata` now runs through `call()`, whose `finally` restores the 
caller TCCL before `leave()`. If catalog replacement calls `close()` while this 
read is in flight, `leave()` becomes the final lease release and 
`closeResources()` closes the Lance namespace/Arrow allocator under the FE/app 
loader. The engine's reclaimer pins only its initial `connector.close()` call, 
so this deferred close can resolve child-first Lance/Arrow classes through the 
wrong loader and fail during ALTER/DROP races. Keep the plugin loader active 
through `leave()`/`closeResources()` (or pin explicitly around the deferred 
close), and add a replacement/read race test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to