csun5285 opened a new pull request, #70840:
URL: https://github.com/apache/doris/pull/70840

   
   
   ### Background
   
   The eight `debug_variant_*` session variables (named `default_variant_*` 
before #70763) are test-only and invisible since #70501: `SHOW VARIABLES` does 
not list them, while `SET` and `SELECT @@` still reach them when 
`enable_debug_points` is true, as in every regression pipeline.
   
   ### What problem does this PR solve?
   
   Issue Number: None
   Related PR: #69995 (added the two suites), #70501 (made the variables 
invisible), #70609 (branch-4.2 pick that carries the same fix)
   PR Type: Test
   
   Problem Summary:
   
   `dotted_key_escape_document_examples` and `dotted_key_escape_semantics` save 
the session value of `debug_variant_enable_nested_group` with `show variables 
like 'debug_variant_enable_nested_group'` and read `[0][1]` of the result. For 
an invisible variable that query returns no row, so both suites fail on every 
run:
   
   ```sql
   show variables like 'debug_variant_enable_nested_group';
   select @@debug_variant_enable_nested_group;
   ```
   
   ```
   Empty set
   +-------------------------------------+
   | @@debug_variant_enable_nested_group |
   +-------------------------------------+
   |                                   0 |
   +-------------------------------------+
   ```
   
   The suites now read the value with `select 
@@debug_variant_enable_nested_group`; its `0` / `1` result is accepted by the 
`SET` that restores the value at the end of each suite.
   
   ### Details
   
   - **Failure:** Both suites fail with `java.lang.NullPointerException: Cannot 
invoke method getAt() on null object` at 
`dotted_key_escape_document_examples.groovy:20` and 
`dotted_key_escape_semantics.groovy:72`, before their checks run.
   - **Cause:** #69995 was merged a few hours after #70501 on 2026-11-16, and 
its two suites read the variable with SHOW VARIABLES, which has returned no row 
for it since #70501. No other suite reads a `debug_variant_*` variable through 
SHOW VARIABLES.
   - **Stability evidence:** The failure does not depend on session values: 
SHOW VARIABLES never lists the variable. `SELECT @@` returns the current 
session value, including a fuzzed one, so the fixed suites restore exactly what 
they saved.
   
   ### Testing
   
   On a local cluster built from master 955f401908f with #70763 applied (the 
two suites and their `.out` files are the same as on current master), with 
`enable_debug_points` and fuzzy session variables on, as in CI:
   
   - Before: both suites of current master fail with the NullPointerException 
above, at lines 20 and 72.
   - After: both suites pass.
   - The SQL output above is from the same cluster.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Behavior changed: No
   - Does this need documentation: No
   - Pre-submission status: Ready
   
   ### AI Disclosure
   
   - Tool: Claude Code (Claude Opus 5.5)
   - Generated: the change, the verification runs, and this description
   - Human review: Approved the approach (read the value with `SELECT @@`) 
before the change was made
   
   <!-- Recommended: develop the change with the develop-with-evidence skill 
and write this description with the doris-pr-description skill, both from 
https://github.com/apache/doris-skills (the doris-skills submodule of this 
repository). -->
   
   ### Background
   
   <!-- How the feature or module this PR touches works today, in two to four 
plain sentences, for a reviewer who doesn't know it. Link the user doc if there 
is one. Leave the problem and the fix to Problem Summary. -->
   
   ### What problem does this PR solve?
   
   <!-- Issue Number: "close #N" if this PR resolves the issue, "#N" if it only 
relates to it, "None" if there is none. A Feature needs an issue. -->
   <!-- Related PR: "#N (relation)" for each PR a reviewer should know about, 
such as "#123 (introduced the bug)", separated by commas. Write "None" if no 
related PR is known. -->
   <!-- PR Type: Bugfix, Performance, Feature, Enhancement, Refactor, Test, 
Build/CI/Chore, Revert, Release/Dependency, or Other. -->
   
   Issue Number:
   Related PR:
   PR Type:
   
   Problem Summary:
   
   <!-- Two to five sentences: the problem or need and who is affected; the 
approach in one sentence; when the diff is larger than that suggests, what else 
it had to handle, or that most of it is tests; and what existing users see 
after an upgrade. -->
   
   ### Details
   
   <!--
   For a diff of more than about 300 changed lines, start with "- **Change 
map:**": how many lines are production code, tests, generated files, and docs, 
then the code in parts, each with the problem it handles and its size.
   Then answer each field of your PR type on its own line, as "- **Field:** 
answer", in this order:
     Bugfix: Frequency, Root cause, Why existing tests missed it, Fix, Other 
paths and branches
     Performance: Why it was slow, Optimization, Results, Applicability and cost
     Feature: Scope, Design, Usage, Default behavior, Compatibility
     Enhancement: Before and after, Configs and defaults, Impact on existing 
users
     Refactor: Moves vs. logic changes, Behavior change, Compatibility, 
Performance impact, Rollback
     Test, adding tests: Scenarios, What existing tests miss, Fails when broken
     Test, fixing a test: Failure, Cause, Stability evidence
     Build/CI/Chore: Affected, Developer and release impact, License and 
third-party, Rollback
     Revert: Why not fix forward, Original author notified, Follow-up
     Release/Dependency: Versions, Upstream changes, Compatibility, Rollback
     Other: Why Other
   "None" is a valid answer when it is true. Don't restate the diff.
   -->
   
   ### Testing
   
   <!-- The tests, suites, or commands that ran, what each shows, and where it 
ran (locally or in CI). For a fix, the test that fails before it and passes 
after. -->
   
   ### Notes for Reviewers
   
   <!-- Optional; delete this section if there is nothing to say. Why each 
non-obvious edit was made, what you are unsure about, and where to start 
reading if Details has no Change map. -->
   
   ### Release note
   
   <!-- One paragraph on what users will notice, or None. -->
   
   ### Check List (For Author)
   
   <!-- Behavior changed: "No", or "Yes (see Details)" with a Behavior change 
field in Details. -->
   <!-- Does this need documentation: "No", or "Yes" with the 
apache/doris-website PR or the plan. -->
   <!-- Pre-submission status: "Ready"; "Partially verified: " and what is not 
verified; or "Not ready: " and why, for a Draft PR. -->
   
   - Behavior changed:
   - Does this need documentation:
   - Pre-submission status:
   
   ### AI Disclosure
   
   <!-- Tool: the agent and model, or None. Generated: the parts it wrote 
(code, tests, this description), or None. Human review: what you reviewed of 
the generated parts, or "Not applicable" without AI tools. You may add "- 
Prompts:" to summarize how you directed the agent. -->
   
   - Tool:
   - Generated:
   - Human review:
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to