github-actions[bot] commented on code in PR #70100:
URL: https://github.com/apache/doris/pull/70100#discussion_r4655976083
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/TopnFilterPushDownVisitor.java:
##########
@@ -214,11 +216,7 @@ private PushDownContext
adjustProbeExprNullableThroughOuterJoin(Plan leftChild,
@Override
Review Comment:
[P1] Guard non-null-producing expressions on nullable outer-join sides.
`canPushToJoinLeft()` only recognizes
`NullToNonNullFunction`/`AlwaysNotNullable`, but scalar `Udf` expressions with
`NullableMode.ALWAYS_NOT_NULLABLE` (for example the existing
`py_nullable_false`, which returns 0 for NULL) and the one-argument
`to_uuid_or_default` are non-null and convert NULL to a value. With a
RIGHT/FULL OUTER JOIN ordered by `py_nullable_false(l.k) NULLS LAST` (or
`to_uuid_or_default(l.k)`), filtering the left scan can remove the matching
row, create a null-extended row, and make that row sort ahead of the bound.
Extend the safety contract to these expressions and add an outer-join
regression before allowing the pushdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]