[GitHub] [doris] SaintBacchus commented on a diff in pull request #16913: [feature-wip](MTMV) Add some metrics for MTMV

Sun, 26 Feb 2023 19:16:32 -0800 


SaintBacchus commented on code in PR #16913:
URL: https://github.com/apache/doris/pull/16913#discussion_r1118242153


##########
fe/fe-core/src/main/java/org/apache/doris/metric/DorisMetricRegistry.java:
##########
@@ -52,11 +50,11 @@ public synchronized void addSystemMetrics(Metric sysMetric) 
{
     }
 
     public synchronized List<Metric> getMetrics() {
-        return Lists.newArrayList(metrics);
+        return 
metrics.stream().sorted(Comparator.comparing(Metric::getName)).collect(Collectors.toList());

Review Comment:
   why sort these metrics?  because it order may be not rigiht as below:
   
   
![image](https://user-images.githubusercontent.com/7404824/221464685-82081443-5d35-450b-be36-5f0e53d60664.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to