adonis0147 commented on PR #15428:
URL: https://github.com/apache/doris/pull/15428#issuecomment-1445860044

   > 
![image](https://user-images.githubusercontent.com/21984011/221502837-4b218569-acfe-4db2-a6ed-2732f4cd777c.png)
 @adonis0147 Excuse me, I would like to ask a question, when get_next from 
child fails in the `_normal_next` function, also should `delete _cur_child`?
   
   In this case, I don't think we should do `delete _cur_child`, because the 
destructor `CollectIterator::Level1Iterator::~Level1Iterator` reclaims these 
memory. Unlike merge, there are no ownership transferring in `OLAPStatus 
CollectIterator::Level1Iterator::init` if we do normal scan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to