HappenLee commented on code in PR #17076:
URL: https://github.com/apache/doris/pull/17076#discussion_r1118758047
##########
be/src/vec/data_types/data_type_decimal.cpp:
##########
@@ -45,25 +51,31 @@ bool DataTypeDecimal<T>::equals(const IDataType& rhs) const
{
template <typename T>
std::string DataTypeDecimal<T>::to_string(const IColumn& column, size_t
row_num) const {
- T value = assert_cast<const
ColumnType&>(*column.convert_to_full_column_if_const().get())
- .get_data()[row_num];
+ auto result = check_column_const_set_readability(column, row_num);
+ ColumnPtr ptr = result.first;
+ row_num = result.second;
+
+ auto value = assert_cast<const ColumnType&>(*ptr).get_element(row_num);
return value.to_string(scale);
}
template <typename T>
void DataTypeDecimal<T>::to_string(const IColumn& column, size_t row_num,
BufferWritable& ostr) const {
- // TODO: Reduce the copy in std::string mem to ostr, like DataTypeNumber
+ auto result = check_column_const_set_readability(column, row_num);
+ ColumnPtr ptr = result.first;
+ row_num = result.second;
+
+ fmt::memory_buffer buffer;
Review Comment:
seems take more mem alloc, not better than old
##########
be/src/vec/data_types/data_type_decimal.cpp:
##########
@@ -45,25 +51,31 @@ bool DataTypeDecimal<T>::equals(const IDataType& rhs) const
{
template <typename T>
std::string DataTypeDecimal<T>::to_string(const IColumn& column, size_t
row_num) const {
- T value = assert_cast<const
ColumnType&>(*column.convert_to_full_column_if_const().get())
- .get_data()[row_num];
+ auto result = check_column_const_set_readability(column, row_num);
+ ColumnPtr ptr = result.first;
+ row_num = result.second;
+
+ auto value = assert_cast<const ColumnType&>(*ptr).get_element(row_num);
return value.to_string(scale);
}
template <typename T>
void DataTypeDecimal<T>::to_string(const IColumn& column, size_t row_num,
BufferWritable& ostr) const {
- // TODO: Reduce the copy in std::string mem to ostr, like DataTypeNumber
+ auto result = check_column_const_set_readability(column, row_num);
+ ColumnPtr ptr = result.first;
+ row_num = result.second;
+
+ fmt::memory_buffer buffer;
Review Comment:
seems take more mem alloc, not better than old
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
