ucasfl commented on code in PR #17218:
URL: https://github.com/apache/doris/pull/17218#discussion_r1119543918
##########
be/src/util/bitmap_value.h:
##########
@@ -1695,8 +1695,7 @@ class BitmapValue {
/**
* Return new set with specified range (not include the range_end)
*/
- int64_t sub_range(const int64_t& range_start, const int64_t& range_end,
- BitmapValue* ret_bitmap) {
+ int64_t sub_range(int64_t range_start, int64_t range_end, BitmapValue*
ret_bitmap) {
Review Comment:
It's prefer `pass by value` than `pass by const reference` for basic data
type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
