HappenLee commented on code in PR #17225:
URL: https://github.com/apache/doris/pull/17225#discussion_r1119993445
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -341,6 +379,44 @@ struct DateFindOp : public CommonFindOp<DateTimeValue> {
void insert(BloomFilterAdaptor& bloom_filter, const void* data) const {
bloom_filter.add_bytes((char*)data,
sizeof(vectorized::VecDateTimeValue));
}
+
Review Comment:
why directly use parent class `CommonFindOp<VecDateTimeValue>` not we do not
have old column exec engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
