yiguolei commented on code in PR #17261:
URL: https://github.com/apache/doris/pull/17261#discussion_r1120981986
##########
be/src/util/broker_storage_backend.cpp:
##########
@@ -72,14 +89,14 @@ Status BrokerStorageBackend::download(const std::string&
remote, const std::stri
constexpr size_t buf_sz = 1024 * 1024;
char read_buf[buf_sz];
Review Comment:
Do not use array to store buffer. Use a vector please. Array will allocate
the buffer on stack and stack is very small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
