yiguolei commented on code in PR #15917:
URL: https://github.com/apache/doris/pull/15917#discussion_r1122663273
##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -458,7 +461,15 @@ Status VScanNode::_normalize_conjuncts() {
RETURN_IF_ERROR(_normalize_predicate((*_vconjunct_ctx_ptr)->root(), &new_root));
if (new_root) {
(*_vconjunct_ctx_ptr)->set_root(new_root);
- } else {
+ if (_should_push_down_common_expr()) {
+ // Copy _vconjunct_ctx_ptr to _common_vexpr_ctxs_pushdown
and push down, mark _vconjunct_ctx_ptr as stale.
Review Comment:
这里不需要这么写； 我感觉只要把两个指针交换一下，然后把_vconjunct_ctx_ptr 设置为nullptr 就行了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
