github-actions[bot] commented on code in PR #17336:
URL: https://github.com/apache/doris/pull/17336#discussion_r1122726419
##########
be/src/vec/functions/functions_comparison.h:
##########
@@ -291,6 +403,75 @@ class FunctionComparison : public IFunction {
return Status::OK();
}
+ Status execute_string(Block& block, size_t result, const IColumn* c0,
const IColumn* c1) {
+ const ColumnString* c0_string = check_and_get_column<ColumnString>(c0);
+ const ColumnString* c1_string = check_and_get_column<ColumnString>(c1);
+ const ColumnConst* c0_const =
check_and_get_column_const_string_or_fixedstring(c0);
+ const ColumnConst* c1_const =
check_and_get_column_const_string_or_fixedstring(c1);
+ if (!((c0_string || c0_const) && (c1_string || c1_const))) {
+ return Status::NotSupported("Illegal columns {}, {} of argument of
function {}",
+ c0->get_name(), c1->get_name(), name);
+ }
+
+ if (c0_const && c1_const) {
+ execute_generic_identical_types(block, result, c0, c1);
+ return Status::OK();
+ }
+
+ const ColumnString::Chars* c0_const_chars = nullptr;
+ const ColumnString::Chars* c1_const_chars = nullptr;
+ ColumnString::Offset c0_const_size = 0;
+ ColumnString::Offset c1_const_size = 0;
+
+ if (c0_const) {
+ const ColumnString* c0_const_string =
+
check_and_get_column<ColumnString>(&c0_const->get_data_column());
+
+ if (c0_const_string) {
+ c0_const_chars = &c0_const_string->get_chars();
+ c0_const_size = c0_const_string->get_data_at(0).size;
+ } else
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
} else {
```
be/src/vec/functions/functions_comparison.h:434:
```diff
- c0->get_name(), name);
+ c0->get_name(), name);
+ }
```
##########
be/src/vec/functions/functions_comparison.h:
##########
@@ -291,6 +403,75 @@
return Status::OK();
}
+ Status execute_string(Block& block, size_t result, const IColumn* c0,
const IColumn* c1) {
+ const ColumnString* c0_string = check_and_get_column<ColumnString>(c0);
+ const ColumnString* c1_string = check_and_get_column<ColumnString>(c1);
+ const ColumnConst* c0_const =
check_and_get_column_const_string_or_fixedstring(c0);
+ const ColumnConst* c1_const =
check_and_get_column_const_string_or_fixedstring(c1);
+ if (!((c0_string || c0_const) && (c1_string || c1_const))) {
+ return Status::NotSupported("Illegal columns {}, {} of argument of
function {}",
+ c0->get_name(), c1->get_name(), name);
+ }
+
+ if (c0_const && c1_const) {
+ execute_generic_identical_types(block, result, c0, c1);
+ return Status::OK();
+ }
+
+ const ColumnString::Chars* c0_const_chars = nullptr;
+ const ColumnString::Chars* c1_const_chars = nullptr;
+ ColumnString::Offset c0_const_size = 0;
+ ColumnString::Offset c1_const_size = 0;
+
+ if (c0_const) {
+ const ColumnString* c0_const_string =
+
check_and_get_column<ColumnString>(&c0_const->get_data_column());
+
+ if (c0_const_string) {
+ c0_const_chars = &c0_const_string->get_chars();
+ c0_const_size = c0_const_string->get_data_at(0).size;
+ } else
+ return Status::NotSupported("Illegal columns {}, of argument
of function {}",
+ c0->get_name(), name);
+ }
+
+ if (c1_const) {
+ const ColumnString* c1_const_string =
+
check_and_get_column<ColumnString>(&c1_const->get_data_column());
+
+ if (c1_const_string) {
+ c1_const_chars = &c1_const_string->get_chars();
+ c1_const_size = c1_const_string->get_data_at(0).size;
+ } else
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
} else {
```
be/src/vec/functions/functions_comparison.h:446:
```diff
- c1->get_name(), name);
+ c1->get_name(), name);
+ }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
